Some bugfixes and minor enhancements #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make much sense to test for a fixed list of TLDs as the list will change every now and then. Instead add some more checks for syntax correctness, and allow a trailing dot; also make the method accept the root domain ".".
If the mailbox part of a RNAME contains dots, they have to be masked with backslashes, making the RNAME an invalid domain name. For such a RNAME to be recognized as valid add a RNAME validation method that only checks the domain part for validity.
|
Hello @NeoRaider, Thanks for your patch. In order to merge the patch, each change must be validated with an unit test. Would you mind to update the patch? -- Simone |
|
Hi @weppos, |
|
I have forked this repository (after attempting and failing to contact author) here: https://github.com/mordocai/net-dns. If you wish to resubmit your pull request there I will review/merge it in. It will shortly be the gem net-dns2 on rubygems.org. |
|
Your changes have been merged in my fork here: https://github.com/mordocai/net-dns/commit/1c779bd981e03f4eb10f37069337760aeab8f586. They should be in the release later this week v0.8.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found this nice library just yesterday and used it to write a minimal DNS server. When writing it I found some annoying bugs, so I fixed them :) I hope the commit messages are self-explaining...